Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail.from not respected for send-magic-link endpoint #20381

Open
1 task done
thebalaa opened this issue Jun 13, 2024 · 7 comments
Open
1 task done

mail.from not respected for send-magic-link endpoint #20381

thebalaa opened this issue Jun 13, 2024 · 7 comments
Assignees
Labels
needs:info [triage] Blocked on missing information P4 - Low

Comments

@thebalaa
Copy link

Issue Summary

setting mail.from is not respected for user registration (via send-magic-link)

Steps to Reproduce

deploy ghost with docker compose, specify mail config options and mail.from notice mails fail to send when smtp provider requires sender identify verification

Ghost Version

5.85.0

Node.js Version

18.20.3

How did you install Ghost?

docker compose

Database type

MySQL 5.7

Browser & OS version

No response

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Jun 13, 2024
@thebalaa
Copy link
Author

Relevant unsuccessful fix: #12802 (comment)

@thebalaa
Copy link
Author

Issue seems to be that the support email is set automatically to noreply@domain but it should probably be populated by mail.from if set

@cmraible
Copy link
Contributor

cmraible commented Jul 4, 2024

Hi @thebalaa, thanks for reporting! Can you please clarify something for me:

Is the issue that the magic link email is sent from an address different than the mail.from configured value, or is the issue that the email fails to send if the SMTP provider requires sender identity verification?

@cmraible cmraible added the needs:info [triage] Blocked on missing information label Jul 4, 2024
@github-actions github-actions bot removed the needs:triage [triage] this needs to be triaged by the Ghost team label Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Note from our bot: The needs:info label has been added to this issue. Updating your original issue with more details is great, but won't notify us, so please make sure you leave a comment so that we can see when you've updated us.

@thebalaa
Copy link
Author

thebalaa commented Jul 4, 2024

Yes, the issue is that magic link email is not sent from the address specific by mail.from.

@linear linear bot removed the needs:info [triage] Blocked on missing information label Jul 12, 2024
@kevinansfield kevinansfield added the P4 - Low label Jul 26, 2024 — with Linear
@sagzy sagzy assigned sagzy and unassigned sagzy Jul 31, 2024
@cmraible
Copy link
Contributor

@thebalaa Thanks for your patience! Can you elaborate on what you mean by this:

fail to send when smtp provider requires sender identify verification

Also if you don't mind sharing which email provider you're using (e.g. Mailgun?) that would be helpful in chasing this down 🙏🏼

@cmraible cmraible self-assigned this Aug 18, 2024
@cmraible cmraible added the needs:info [triage] Blocked on missing information label Sep 17, 2024
Copy link
Contributor

Note from our bot: The needs:info label has been added to this issue. Updating your original issue with more details is great, but won't notify us, so please make sure you leave a comment so that we can see when you've updated us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:info [triage] Blocked on missing information P4 - Low
Projects
None yet
Development

No branches or pull requests

4 participants