-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site visit not being populate when retrieving from deployment. #270
Comments
Deployed. |
I actually don't think we want it to auto-populate the site visit. If it does, it populates with the same site visit for which the deployment occurred - which is not likely to be when the retrieval occurred. What would be helpful, though, is to ensure that the site visit selected for retrieval has a DateTime that is AFTER the DateTime of the site visit associated with the deployment. |
Sounds good, changing this behavior, will push soon. |
Ok - I think this is ok, though there is no logic to ensure that the retrieval occurs after the deployment. How hard would that be to implement? |
Let me look in to it, and I will try and work this in with the next batch of merges. |
This is unchanged, right? |
Yes, sorry. |
Logic to ensure retrieval occurs after deployment now exists. |
I don't think this is performing as desired. It appears that the logic is there because when I select a site visit for retrieval that was prior to the deployment, I get an error, while if I select a site visit visit for retrieval that is after the deployment, it correctly retrieves. However, this behavior is not helpful or clear to the user. My preference is that the site visits prior to the deployment are not even options in the drop down. Another potential solution is that the user is returned to the form with a message that states "Select a Site Visit for Retrieval that is after the Site Visit of the Deployment." |
I see! I will get on that right now. |
When retrieving from deployment details, it doesn't auto-populate the site visit. This is problematic.
Have solution, haven't pushed yet.
The text was updated successfully, but these errors were encountered: