Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualifiers do not appear in exported file #118

Open
AmberSJones opened this issue Feb 2, 2018 · 6 comments
Open

Qualifiers do not appear in exported file #118

AmberSJones opened this issue Feb 2, 2018 · 6 comments
Labels

Comments

@AmberSJones
Copy link
Contributor

When I export data, the qualifier code is blank. I am pretty sure that there are values for some of these in the underlying database, so unsure why none appear. Did this not translate to influx?

@horsburgh
Copy link
Member

@fryarludwig - can you at least diagnose this?

@fryarludwig
Copy link
Contributor

The influx database currently only stores the datavalue, the UTC offset, and the timestamp in milliseconds for each series. The qualifiers and censor codes (#117) could be added to the influx database, doubling the influx database in size for every data series, and there wouldn't likely be any issues with performance. I don't recommend that though - we want to keep the "columns" in the database to their absolutely minimum to make sure we keep its current performance and reliability.

I think the solution here is to, for every scenario in which we need more than the timestamp, UTC offset, and datavalue, we pull that from the postgres database. @jcaraballo17 or @Maurier could make the changes to generate the CSV file from postgres.

@fryarludwig
Copy link
Contributor

Do we need to worry about CSV file generation for USGS datavalues?

@horsburgh
Copy link
Member

@fryarludwig - I think the functionality should be consistent. If the USGS data are available in the TSA, you should be able to download them just like the other data. Is there a reason why we wouldn't do that?

@horsburgh
Copy link
Member

@fryarludwig - another note - if the InfluxDB is being used to generate the CSV files for download, then it needs to store all value-level attributes, including qualifiers and censor codes. It doesn't make sense to use the InfluxDB for the CSV files if it lacks value-level attributes because you would have to go re-query the datavalues from the PostgreSQL database to match up data values with their CensorCodes and Qualifiers anyway.

@fryarludwig
Copy link
Contributor

I think those are good arguments for including the qualifier and censor information in the Influx database, and it's the simpler route. I'll see what it takes to add the columns and update this issue.

@fryarludwig fryarludwig removed their assignment Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants