Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it model agnostic #3

Open
ocefpaf opened this issue May 29, 2015 · 3 comments
Open

Make it model agnostic #3

ocefpaf opened this issue May 29, 2015 · 3 comments

Comments

@ocefpaf
Copy link
Member

ocefpaf commented May 29, 2015

For now it is specific to ROMS.

@rsignell-usgs
Copy link
Member

Yeah, I guess we can look forward to --roms, --fvcom, --selfe, etc.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jun 28, 2015

This is something we need to think before re-factoring. One idea is to ship templates for roms, fvcom, selfe, etc and load them using a mandatory argument like --model=<model_arg>.

Ee can treat the current implementation as a roms template, factor it out, and providing a model for future templates.

@ocefpaf
Copy link
Member Author

ocefpaf commented Dec 15, 2016

Instead of --model_name we can do that via templates. See #31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants