If a critical module fails, uProxy should die (or restart the module)

[bemasc]

Currently, if the social provider fails, there is no indication in the user interface. User actions just have no effect. This is bad. Instead, we should either fail hard and show an error message, or recover from the failure somehow.

Either solution will likely involve using the module's onClose method.

[iislucas]

What kind of failure are you thinking of, exceptions?
(If the social provider is disconnected, then @dborkan 's new fix should notify the UI: freedomjs/freedom-social-xmpp#93 or is there other stuff we're missing?).

Are you thinking of a top-level exception that kills the web-worker? I think later versions of freedom (0.7) & later are planning to do module-monitoring and optional re-start/error reporting. In which case, I think this is best for v2.

[ryscheng]

We already give you the ability to check when a module is closed by
registering an onClose event handler for a module. That's probably a good
thing to add.

On Wed, Feb 11, 2015 at 2:19 PM, iislucas [email protected] wrote:

What kind of failure are you thinking of, exceptions?
(If the social provider is disconnected, then @dborkan
https://github.com/dborkan 's new fix should notify the UI:
freedomjs/freedom-social-xmpp#93
freedomjs/freedom-social-xmpp#93 or is there
other stuff we're missing?).

Are you thinking of a top-level exception that kills the web-worker? I
think later versions of freedom (0.7) & later are planning to do
module-monitoring and optional re-start/error reporting. In which case, I
think this is best for v2.

—
Reply to this email directly or view it on GitHub
#895 (comment).

[iislucas]

I see, cool. +1

[salomegeo]

what was the error?

[bemasc]

#894 is one example that had this behavior.

[salomegeo]

blocked on freedomjs/freedom#231

[bemasc]

Based on the next comment in freedomjs/freedom#231
freedomjs/freedom#231, it seems like this is
not blocked after all.

On Fri, Feb 20, 2015 at 5:57 PM, salomegeo [email protected] wrote:

blocked on freedomjs/freedom#231
freedomjs/freedom#231

—
Reply to this email directly or view it on GitHub
#895 (comment).

[salomegeo]

@zahoriea we don't just want to restart the app and the extension without asking users first. We were thinking maybe we should display something to ask users to restart the app.

[dborkan]

Depending on which module fails, we can probably fail more gracefully than
restarting the whole app. E.g. if a social module fails it should just log
them out, if socks-to-rtc or rtc-to-net fail (both will be freedom modules
soon) it should just end the proxy session maybe with an error displayed
On Mar 9, 2015 8:56 PM, "salomegeo" [email protected] wrote:

@zahoriea https://github.com/zahoriea we don't just want to restart the
app and the extension without asking users first. We were thinking maybe we
should display something to ask users to restart the app.

—
Reply to this email directly or view it on GitHub
#895 (comment).

[iislucas]

Failures we (may) have to deal with:

• logging provider
• main module
  • When they run in their own module (pending require changes) also: socks-rtc, rtc-net.
• social provider
• core environment.

I'd suggest for a v1 that we do something simple (but sub-optimal) like showing an unhappy uproxy face in the popup; stopping the chrome-app (for security); and letting the user click a button to restart the chrome app and or give us feedback. We can get fancier later, but in the short term we probably want to know when things break like this.

[iislucas]

De-assigning as no one is actually working on this right now.