Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Micrometer #280

Open
bikerp opened this issue Feb 10, 2025 · 2 comments
Open

Add support for Micrometer #280

bikerp opened this issue Feb 10, 2025 · 2 comments
Assignees

Comments

@bikerp
Copy link

bikerp commented Feb 10, 2025

Describe the feature request

I would appreciate if Unleash supports Micrometer/Prometheus metrics for http client requests

Background

No response

Solution suggestions

No response

@FredrikOseberg FredrikOseberg moved this from New to Investigating in Issues and PRs Feb 12, 2025
@chriswk chriswk self-assigned this Feb 12, 2025
@chriswk
Copy link
Member

chriswk commented Feb 12, 2025

Hi @bikerp. We're trying to avoid adding more libraries, so we will not be adding prometheus/micrometer as a direct dependency.

However, we'd be open to add more hooks that you could hook into or more events that you could write an event listener to handle. That would allow our users most flexibility when it comes to deciding what useful metrics are for them.

If you'd like to describe which metrics you're missing, or add a PR with events/hooks I'd definitely be willing to help you get it approved and merged.

@bikerp
Copy link
Author

bikerp commented Feb 12, 2025

I think the only soultion now is to provide custom FeatureFetcher. I think that FeatureFetcher could be more generic and could accept any http client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Investigating
Development

No branches or pull requests

2 participants