From 94099875e4d9178ab4c9111790814d5b10f662b6 Mon Sep 17 00:00:00 2001 From: kwasniew Date: Fri, 20 Dec 2024 12:10:42 +0100 Subject: [PATCH] fix: remove meta tag in streaming handler --- src/repository/index.ts | 8 +------- src/test/repository.test.ts | 11 +++-------- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/src/repository/index.ts b/src/repository/index.ts index 29536560..4608e25d 100644 --- a/src/repository/index.ts +++ b/src/repository/index.ts @@ -132,13 +132,7 @@ export default class Repository extends EventEmitter implements EventEmitter { if (this.eventSource) { this.eventSource.addEventListener('unleash-updated', (event: { data: string }) => { try { - const data: ClientFeaturesResponse & { meta: { etag: string } } = JSON.parse(event.data); - const etag = data.meta.etag; - if (etag !== null) { - this.etag = etag; - } else { - this.etag = undefined; - } + const data: ClientFeaturesResponse = JSON.parse(event.data); this.save(data, true); } catch (err) { this.emit(UnleashEvents.Error, err); diff --git a/src/test/repository.test.ts b/src/test/repository.test.ts index 1600bc99..65cc032c 100644 --- a/src/test/repository.test.ts +++ b/src/test/repository.test.ts @@ -1363,7 +1363,7 @@ test('Stopping repository should stop storage provider updates', async (t) => { }); test('Streaming', async (t) => { - t.plan(6); + t.plan(4); const url = 'irrelevant'; const feature = { name: 'feature', @@ -1408,22 +1408,17 @@ test('Streaming', async (t) => { // update with feature eventSource.emit('unleash-updated', { type: 'unleash-updated', - data: JSON.stringify({ meta: {}, features: [feature] }), + data: JSON.stringify({ features: [feature] }), }); const firstUpdate = repo.getToggles(); t.deepEqual(firstUpdate, [feature]); - // @ts-expect-error - t.is(repo.etag, undefined); - // update with etag eventSource.emit('unleash-updated', { type: 'unleash-updated', - data: JSON.stringify({ meta: { etag: 'updated' }, features: [] }), + data: JSON.stringify({ features: [] }), }); const secondUpdate = repo.getToggles(); t.deepEqual(secondUpdate, []); - // @ts-expect-error - t.is(repo.etag, 'updated'); // SSE error translated to repo warning repo.on('warn', (msg) => {