Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Favicons Not Displaying on Helpful Links Cards #725

Open
chrissantillan opened this issue Feb 4, 2025 · 3 comments · May be fixed by #738
Open

BUG: Favicons Not Displaying on Helpful Links Cards #725

chrissantillan opened this issue Feb 4, 2025 · 3 comments · May be fixed by #738
Assignees
Labels
bug Something isn't working

Comments

@chrissantillan
Copy link
Collaborator

Describe the Bug

Some Helpful Links in the Knowledge Center do not display their respective favicons as the thumbnail for their cards. Additionally, when a favicon fails to load, the default UnlockEd icon (Unlocked Labs logo) is not being used as a fallback.

To Reproduce

  1. Go to the Knowledge Center > Helpful Links tab.
  2. Scroll to the following links:
    • 211 Maine
    • Concord Coach
    • Cyr Bus Line
    • Monster.com
    • Recovery Connections of Maine
    • Workforcesolutionsme
  3. Observe that the favicon does not appear as the thumbnail for these Helpful Link cards.
  4. If the favicon is missing, the card should fall back to displaying the default UnlockEd icon, but it does not.

Expected Behavior

  • Each Helpful Link card should display the website’s favicon as its thumbnail.
  • If the favicon fails to load, the default UnlockEd icon should be used as the thumbnail instead.

Screenshot

Image

Additional Context

The following are the HTML favicon tags from the respective sites:

  1. 211 Maine
    <link rel="icon" href="https://211maine.org/wp-content/uploads/2017/10/211_favicon.png" sizes="32x32">
  2. Concord Coach
    <link rel="icon" href="https://concordcoachlines.com/wp-content/uploads/2016/04/cropped-cc-favicon-200x200.png" sizes="32x32">
  3. Cyr Bus Line
    <link rel="shortcut icon" sizes="16x16 32x32 64x64" href="/files/2020/03/sa.png?w=196&amp;h=196&amp;zc=0">
  4. Monster.com
    <link data-react-helmet="true" rel="shortcut icon" href="/favicon.ico">
  5. Recovery Connections of Maine
    <link rel="shortcut icon" sizes="16x16 32x32 64x64" href="/files/2020/08/favicon.png?w=196&amp;h=196&amp;zc=0">
  6. Workforcesolutionsme
    <link rel="shortcut icon" sizes="16x16 32x32 64x64" href="/cms_websites/img/tsm-favicon.ico">

Potential Fixes to Investigate

  • Ensure the application correctly retrieves and sets the favicon URL as the card thumbnail.
  • If the favicon URL is a relative path (e.g., /favicon.ico), prepend the site's domain to construct a full URL.
  • If the favicon fails to load (or is not present in the site’s metadata), fallback to displaying the default UnlockEd icon.
  • Ensure the frontend logic properly updates the card thumbnails after a failed favicon fetch.
@chrissantillan chrissantillan added the bug Something isn't working label Feb 4, 2025
@jtucholski
Copy link
Contributor

@chrissantillan Good find. Is this marked high relative to other tasks in the sprint or relative to how the feature is supposed to work?

@chrissantillan
Copy link
Collaborator Author

@jtucholski high relative to the other tasks

@jtucholski
Copy link
Contributor

Related to #702

@CK-7vn CK-7vn self-assigned this Feb 13, 2025
@CK-7vn CK-7vn linked a pull request Feb 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants