Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cockroach Kotlin generation. #390

Closed
wants to merge 1 commit into from

Conversation

kylepl
Copy link

@kylepl kylepl commented Oct 27, 2023

Task

Resolves: #389

Description

Add supports for coackroach DB Kotlin generation.

This was done by look at an example like digitalocean: https://github.com/search?q=repo%3AVirtuslabRnD%2Fpulumi-kotlin%20digitalocean&type=code

Note that the JSON source owner is not pulumi in this case, but lbrlabs, as pointed to by https://www.pulumi.com/registry/packages/cockroach/.

This was done by look at an example like digitalocean:
https://github.com/search?q=repo%3AVirtuslabRnD%2Fpulumi-kotlin%20digitalocean&type=code

Note that the JSON source owner is not pulumi in thsi case, but lbrlabs,
as pointed to by https://www.pulumi.com/registry/packages/cockroach/.
@kylepl kylepl requested a review from a team as a code owner October 27, 2023 17:49
@kylepl kylepl requested review from myhau and jplewa October 27, 2023 17:49
@myhau
Copy link
Member

myhau commented Oct 27, 2023

Hi Kyle :)

Thanks for taking the time to create this PR. Cockroach would indeed be a valuable addition to the list of supported providers!

There is one problem, though. pulumi-kotlin is implemented as a wrapper on top of Pulumi Java SDK (see our docs for a bit more context).
This means that it can only support providers which were released to Maven Central Repository by the Pulumi team (example for Kubernetes).

Could you please raise an issue about Cockroach support in pulumi-java repository and maybe mention this PR / issue?

@kylepl
Copy link
Author

kylepl commented Oct 27, 2023

Ah, yeah, that makes sense.

Filed pulumi/pulumi-java#1260.

@kylepl
Copy link
Author

kylepl commented Nov 1, 2023

So I'm attempting to start exporting this in pulumiverse/pulumi-cockroach#9, we'll see how it goes.

IIUC, all the existing providers are published by pulumi, but this is done by a third-party, so the maven path with not be com.pulumi, but probably org.lbrlabs - but I don't think my commit expresses that (it does have a different schema URL, but do not see where this would be changed for the Maven path)

I may also experiment with building the Kotlin SDK locally (with https://github.com/VirtuslabRnD/pulumi-kotlin/blob/main/docs/code-generation.md), to unblock myself.

@jplewa
Copy link
Member

jplewa commented Apr 19, 2024

@kylepl Hi, closing this PR for now (but obviously keeping the issue). We can reopen it when the Java library becomes available

@jplewa jplewa closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support cockroachDB
3 participants