Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please improve types of ariaLabels prop #1085

Closed
mkeyy0 opened this issue Mar 3, 2025 · 0 comments
Closed

Please improve types of ariaLabels prop #1085

mkeyy0 opened this issue Mar 3, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@mkeyy0
Copy link

mkeyy0 commented Mar 3, 2025

Describe the bug
According to the documentation and implementation, some aria labels can be omitted. The default will be used if no aria label is provided for specific cases. But in the current implementation, the date-picker component doesn't allow to pass individual aria-labels based on the type definitions

To Reproduce
Pass any optional aria label. For example, amPmButton and see the error

Expected behavior
Allow to omit some of aria label definitions on the type level

Screenshots

Image

Package versions:
TypeScript version: 5.6
Vue version: 3.4

@mkeyy0 mkeyy0 added awaiting triage The issue is not reviewed by the maintainers bug Something isn't working labels Mar 3, 2025
@Jasenkoo Jasenkoo removed the awaiting triage The issue is not reviewed by the maintainers label Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants