Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide presets for both "script-free" and "fetch free" #57

Open
Jamesernator opened this issue Feb 4, 2021 · 2 comments
Open

Provide presets for both "script-free" and "fetch free" #57

Jamesernator opened this issue Feb 4, 2021 · 2 comments
Milestone

Comments

@Jamesernator
Copy link

Currently the design of the sanitizer API seems to only be concerned with XSS, this means blocking all forms of scripting (e.g. onevent, <script>, etc).

However a weaker class of attacks still exist that may be used to exfiltrate data about users, and that is the ability to trigger any form of request to a third party (or sometimes even first party) resource.

For example, this image tag could be used to exfiltrate how many people view a particular piece of user generated content:

<img src="https://evil.bad/honeypot.png">

Many other examples exist however, such as <a ping="...">, <link rel="stylesheet">, etc etc

As such I'd like to suggest having a second preset that will strip all elements/attributes that could trigger a fetch.

@mozfreddyb
Copy link
Collaborator

Thanks for the suggestion, @Jamesernator! We'll look at offering presets for common use-cases once we get there. It's definitely in scope.

@otherdaniel otherdaniel mentioned this issue Apr 23, 2021
@benbucksch
Copy link

benbucksch commented May 12, 2021

+1

The sanitizer in Mozilla has this as explicitly stated goal, that loading a network resource is a bug. Network resources allow tracking by third parties, which is usually unwanted. This is true not only for email clients, but in many contexts where you want to sanitize the HTML.

Video decoders particularly are also very vulnerable to memory safety bugs, due to their complexity and performance-oriented implementation.

@mozfreddyb mozfreddyb added this to the v2 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants