Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function GET_APP_ID_BY_DOMAIN_NAME is in the wrong file. #22

Open
elindydotcom opened this issue Feb 10, 2022 · 0 comments
Open

Function GET_APP_ID_BY_DOMAIN_NAME is in the wrong file. #22

elindydotcom opened this issue Feb 10, 2022 · 0 comments
Labels
good first issue Good for newcomers Priority: Medium Medium priority

Comments

@elindydotcom
Copy link
Contributor

The function GET_APP_ID_BY_DOMAIN_NAME likely needs to be moved down into the class-wordpress-app.php file. This is because it is a wordpress-app specific function. Other apps do not know anything about a domain name so this function should not really be all the way up in the class hierarchy.

We just need to be careful to search the code base to make sure that we are indeed only using this function in the wordpress app before moving it.

@elindydotcom elindydotcom added good first issue Good for newcomers Priority: Medium Medium priority labels Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Priority: Medium Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant