Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we check that URI matches domain when using ReCaps? #400

Open
chris13524 opened this issue Mar 8, 2024 · 0 comments
Open

Should we check that URI matches domain when using ReCaps? #400

chris13524 opened this issue Mar 8, 2024 · 0 comments
Labels

Comments

@chris13524
Copy link
Member

There is currently a disabled test that for when using ReCaps tests that we verify that the domain in URI and domain fields of the SIWE match each other.

Prior to ReCaps, we intentionally did not check that these matched because the URI field was used for the identity key which would not match. This was unsupported in Brave but we believe that these fields are unrelated.

Question is do we check if the domains match or not?

Slack conversation

@arein arein added the accepted label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants