-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use _glm
functions when applicable.
#22
Comments
The column-of-1s trick shortens the notation, but it's more efficient to not multiply by 1 and just use You usually want a broader prior on the intercept than on coefficients, too, because it soaks up all the excess from all the other effects. Is the |
|
That makes more sense. I had to look up that Wilkinson formula syntax is what lme4 and brms use. Wilkinson was also behind the grammar of graphics which is the basis for ggplot2. If the column of 1s is going to be forced on you, do you at least know which column it is so that you can define separate priors for intercepts? |
I think the convention is that the column of 1s comes first. When talking to @jgabry he mentioned that RStanArm checks for this and removes that first column, preferring to use the true intercept parameter. In the long term, I'd like to make a package using a formula implementation like formulae and scikit-stan as a "backend" to make something which looks very much like rstanarm. In that package, I am planning on doing that same chop, but for the lower-level interface we wanted to allow the customization if necessary. |
For example, normal_id_glm, or bernoulli_logit_glm. These are much faster due to reduced autodiff.
We may need to re-factor how our models are structured to best use these. Also, these assume a separate intercept, so we will need to avoid using
X
with a column of all ones/disable when usingfit_intercept=False
The text was updated successfully, but these errors were encountered: