Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Interpreter] i32/i64 Bitwise Operators #7332

Merged
merged 1 commit into from
Feb 27, 2025
Merged

[Interpreter] i32/i64 Bitwise Operators #7332

merged 1 commit into from
Feb 27, 2025

Conversation

ashleynh
Copy link
Collaborator

@ashleynh ashleynh commented Feb 27, 2025 •
edited
Loading

Building on #7227, implemented and tested the following:

  • i32/i64.and
  • i32/i64.or
  • i32/i64.xor
  • i32/i64.shl
  • i32/i64.shrU
  • i32/i64.shrS
  • i32/i64.rotL
  • i32/i64.rotR

@ashleynh ashleynh requested a review from tlively February 27, 2025 00:46
tlively
tlively approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@tlively tlively left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a more descriptive commit title and body.

@ashleynh ashleynh changed the title xor [Interpreter] i32/i64 Bitwise Operators Feb 27, 2025
@ashleynh ashleynh merged commit 7142fa1 into main Feb 27, 2025
14 checks passed
@ashleynh ashleynh deleted the xoror branch February 27, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleynh @tlively