Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use safer GITHUB_OUTPUT #2540

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

SoniEx2
Copy link
Collaborator

@SoniEx2 SoniEx2 commented Feb 13, 2025

Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some way we can test this or confirm its correct? Or do we just need to wait for a release?

@SoniEx2
Copy link
Collaborator Author

SoniEx2 commented Feb 13, 2025

the wasi job uploads artifacts, which is how we came across the deprecation warnings. and it seems to be still working. you can see them here: https://github.com/WebAssembly/wabt/actions/runs/13314673812/attempts/1?pr=2540

@SoniEx2
Copy link
Collaborator Author

SoniEx2 commented Feb 13, 2025

(we hope that s390x failure was some sort of spurious bitflip...)

@sbc100 sbc100 merged commit 508984b into WebAssembly:main Feb 13, 2025
18 checks passed
@SoniEx2 SoniEx2 deleted the modern-workflow-output branch February 13, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants