Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback #2

Open
mhayen opened this issue Sep 1, 2024 · 2 comments
Open

Feedback #2

mhayen opened this issue Sep 1, 2024 · 2 comments
Assignees
@WildH0g

Comments

@mhayen
Copy link

mhayen commented Sep 1, 2024

Hi Dmitry,
I submitted a PR with some small improvements I hope at least.
This one

Please give me you feedback.

Mark
@WildH0g WildH0g self-assigned this Sep 3, 2024
@WildH0g
Copy link
Owner

WildH0g commented Sep 3, 2024

Hi Mark,

Thanks for your interest and contributions! I've left come comments in the code review. Going forward, please do the following:

  1. Open an issue before making a pull request, this will save us a lot of time and effort :)
  2. Make your PRs smaller please. You have multiple changes here, they need to be atomic (getting started is one PR, .gitignore is another one ... they are different features and don't belong together).

@WildH0g
Copy link
Owner

WildH0g commented Sep 20, 2024

@mhayen Hey Mark, haven't heard from you in a while, do you intend to continue with the PR? Let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WildH0g WildH0g

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhayen @WildH0g