Analyzer to warn against SQL varchar parameters without a max length

[bretehlert]

When constructing a SqlParameter or adding a parameter to an SqlParameterCollection, and the parameter type is (n)varchar, a max length should always be specified. If a max length is not specified then the length of the value is used causing a different execution plan each different length of parameter value.

Examples of violations include:

new SqlParameter("@parameter", SqlDbType.VarChar) { Value = value },
new SqlParameter("parameter", value)
cmd.Parameters.AddWithValue("parameter", value);
cmd.Parameters.Add("parameter", SqlDbType.VarChar)

[yaakov-h]

Does setting the size to -1 specify a max-length execution plan every time, or does SQL still generate different execution plans based on the string length?