Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background Image: Add placeholder #69243

Open
hanneslsm opened this issue Feb 19, 2025 · 5 comments · May be fixed by #69244
Open

Background Image: Add placeholder #69243

hanneslsm opened this issue Feb 19, 2025 · 5 comments · May be fixed by #69244
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@hanneslsm
Copy link

What problem does this address?

When a Group has no background image, it only displays the text "Add background image".
However, on the left of the text the placeholder (grey crossed out circle) is missing.

Image

What is your proposed solution?

Add the placeholder as it is on the colors.

Info: When an image is added it's also displayed in a circle, so the placeholder can be same as for the colors.

Image
@hanneslsm hanneslsm added the [Type] Enhancement A suggestion for improvement. label Feb 19, 2025
@hanneslsm hanneslsm changed the title Group Background Image: Add placeholder Background Image: Add placeholder Feb 19, 2025
@Mayank-Tripathi32
Copy link
Contributor

Hello @hanneslsm,

Thank you for reporting the issue. I believe the background image block follows the "featured image" placeholder and maintains consistency with other image placeholders. Don't you think?

@hanneslsm
Copy link
Author

You mean this featured image placeholder?
Since this is a button, I think this is a different use case. No need to be consistent with it.

Image

@Mayank-Tripathi32
Copy link
Contributor

Mayank-Tripathi32 commented Feb 19, 2025

You mean this featured image placeholder? Since this is a button, I think this is a different use case. No need to be consistent with it.

Background images are added as a support, so changing their behavior could impact other areas as well. We'll need to test all possible instances where they are used.

@hanneslsm
Copy link
Author

Background images are added as a support, so changing their behavior could impact other areas as well. We'll need to test all possible instances where they are used.

I'm not sure if I understood.
This issue is only about displaying the indicator when no background is set. (Grey circle with diagonal line)

@Mayank-Tripathi32
Copy link
Contributor

Background images are added as a support, so changing their behavior could impact other areas as well. We'll need to test all possible instances where they are used.

I'm not sure if I understood. This issue is only about displaying the indicator when no background is set. (Grey circle with diagonal line)

Yes, my bad. I've opened the PR with the required changes and will add the information there. It shouldn't be an issue to add the placeholder.

@t-hamano t-hamano added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants