Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update auto sizes logic in Enhanced Responsive Images plugin to no longer load if already in Core #1531

Closed
felixarntz opened this issue Sep 11, 2024 · 2 comments · Fixed by #1547
Closed

Update auto sizes logic in Enhanced Responsive Images plugin to no longer load if already in Core #1531

felixarntz opened this issue Sep 11, 2024 · 2 comments · Fixed by #1547
Assignees
@mukeshpanchal27
Labels
[Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) [Type] Enhancement A suggestion for improvement of an existing feature
Milestone
auto-sizes 1.3.0

Comments

@felixarntz
Copy link
Member

Per the core code being merged in https://core.trac.wordpress.org/changeset/59008, we need to modify the Enhanced Responsive Images plugin to ensure the relevant logic is only loaded if not already available in Core, for compatibility with the upcoming 6.7 release.

Maybe a good way would be to check for existence of the wp_sizes_attribute_includes_valid_auto() function?

We still have some time to do that, but good to have an issue already. We could get started on this at any point prior to the WP 6.7 release.
@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) labels Sep 11, 2024
@felixarntz
Copy link
Member Author

cc @joemcgill @mukeshpanchal27

@joemcgill
Copy link
Member

💥 I was just having this thought after committing https://core.trac.wordpress.org/changeset/59008. Thanks for opening this.

@mukeshpanchal27 mukeshpanchal27 self-assigned this Sep 11, 2024
@mukeshpanchal27 mukeshpanchal27 mentioned this issue Sep 19, 2024
Merged
@westonruter westonruter added this to the auto-sizes 1.3.0 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
[Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) [Type] Enhancement A suggestion for improvement of an existing feature
Projects
WP Performance 2024
Status: Done 😃
Milestone
auto-sizes 1.3.0
4 participants
@westonruter @joemcgill @felixarntz @mukeshpanchal27