Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Navigation Modal trends towards being obscured by body content / restricted by containing DIV #673

Closed
quix-cafe opened this issue Nov 11, 2024 · 3 comments
Labels
[Type] Bug An existing feature does not function as intended.

Comments

@quix-cafe
Copy link

quix-cafe commented Nov 11, 2024

Description
Upon customization of the 2025 Theme Navigation, I keep having to chase down bugs that result in the Modal pop-up of the Mobile-version "hamburger" menu being either restricted by the containing DIV of the Nav, or being z-indexed below the body content. I believe this is because the Modal tag is being placed within the Nav, rather than separately after the Body tag.

Step-by-step reproduction instructions

Expected behavior
A full-screen modal menu pops up

Screenshots
The portion that intersects with the Header is the only part visible.

Environment info
Reproducible on Firefox, Chrome, Mobile Firefox, Mobile Chrome

@quix-cafe quix-cafe added the [Type] Bug An existing feature does not function as intended. label Nov 11, 2024
@carolinan
Copy link
Contributor

I am afraid I am struggling to understand what you mean.

Without more information, there is no way for me to help determine if the problem is with the theme, the customisations, or with the block itself.

And I am not sure what a "Modal tag" is.

@carolinan
Copy link
Contributor

The navigation must be inside a <nav> element, because the menu must be a semantic navigation, even on smaller screens.
The markup for the menu is added by the block, not by the theme. The theme only positions the navigation block and adds color and typography styles.

@quix-cafe
Copy link
Author

I've learned so much about Blocks in the past 24 hours -- my apologies -- you are absolutely correct that themes no longer effect the code that I was looking at. I'm a bit of a dinosaur -- cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

No branches or pull requests

2 participants