Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JwtSessionModule and AbstractJwtSessionModule are incompatible when handling Max-Age cookie attribute #22

Open
pavelhoral opened this issue Dec 2, 2020 · 0 comments
Open

JwtSessionModule and AbstractJwtSessionModule are incompatible when handling Max-Age cookie attribute #22

pavelhoral opened this issue Dec 2, 2020 · 0 comments

Comments

@pavelhoral
Copy link
Member

pavelhoral commented Dec 2, 2020 •
edited
Loading

JwtSessionModule is setting Max-Age cookie attribute to negative value to mark it as a session cookie. This is in line with ServletJwtSessionModule that does the same, however CHF Cookie API is not the same as javax.servlet Cookie API in a sense that negative Max-Age will automatically expire the cookie.

JwtSessionModule needs to handle negative max-age according to AbstractJwtSessionModule#getCookieMaxAge's contract.

This issue breaks Wren:IDM's authentication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pavelhoral