Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common-links.md should dynamically change links depending on language #2682

Open
tequdev opened this issue Jul 16, 2024 · 1 comment
Open

common-links.md should dynamically change links depending on language #2682

tequdev opened this issue Jul 16, 2024 · 1 comment
Labels
localization organization Information architecture, restructuring, interlinking, etc.

Comments

@tequdev
Copy link
Contributor

tequdev commented Jul 16, 2024

https://github.com/XRPLF/xrpl-dev-portal/blob/f74f61149c8de2b32bdbf86ae8d190531159c3e2/docs/_snippets/common-links.md

Especially in entries that are used in both Japanese and English, such as
[API v1]: /docs/references/http-websocket-apis/api-conventions/request-formatting.md#api-versioning,
it currently will only take you to the English page.
@tequdev
Copy link
Contributor Author

tequdev commented Jul 16, 2024

It'd be nice if the root of the link could be changed to xrpl.org for English and xrpl.org/[lang]/ for other languages.

@mDuo13 mDuo13 added localization organization Information architecture, restructuring, interlinking, etc. labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
localization organization Information architecture, restructuring, interlinking, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mDuo13 @tequdev