Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faucets page - rename faucetUrl to faucetHost #2725

Open
mDuo13 opened this issue Aug 13, 2024 · 1 comment
Open

Faucets page - rename faucetUrl to faucetHost #2725

mDuo13 opened this issue Aug 13, 2024 · 1 comment
Labels
bug Typo or other small documentation error dev-tools good first issue Community contributions to these issues are especially welcome!

Comments

@mDuo13
Copy link
Collaborator

mDuo13 commented Aug 13, 2024

It's not actually supposed to contain a URL, so that's confusing for maintenance every time we add a new faucet.

Modify https://github.com/XRPLF/xrpl-dev-portal/blob/master/resources/dev-tools/xrp-faucets.page.tsx and https://github.com/XRPLF/xrpl-dev-portal/blob/master/resources/dev-tools/faucets.json to change the faucetUrl field to be something more accurate, probably faucetHost.

Alternatively, we could modify it to actually take a URL.

@mDuo13 mDuo13 added bug Typo or other small documentation error good first issue Community contributions to these issues are especially welcome! dev-tools labels Aug 13, 2024
@mDuo13
Copy link
Collaborator Author

mDuo13 commented Aug 13, 2024

Also for some reason the spinner/loading animation that used to show while it's waiting to get your balance information isn't there anymore, and it would be nice to put that back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Typo or other small documentation error dev-tools good first issue Community contributions to these issues are especially welcome!
Projects
None yet
Development

No branches or pull requests

1 participant