Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserves #2

Open
alloynetworks opened this issue May 25, 2021 · 5 comments
Open

Reserves #2

alloynetworks opened this issue May 25, 2021 · 5 comments
Assignees

Comments

@alloynetworks
Copy link
Contributor

The rippled.cfg that is generated also creates the [voting] values without prompt. This should be a form to either accept the default or set custom values.

@github-actions
Copy link

Thanks for creating your first issue :-)

@elmurci
Copy link
Collaborator

elmurci commented May 25, 2021

Thanks @alloynetworks for this.

If I read it correctly, you are saying that the tool should either remove the voting section to apply defaults or allow custom settings in the UI, right?

@alloynetworks
Copy link
Contributor Author

That is correct. If a voting section isn't present, it will take defaults. However, the defaults are hard coded as it stands in rippled, and those are subject to change by [voting]. This requires a bit of discussion, so that operators don't put arbitrary values there.

@elmurci
Copy link
Collaborator

elmurci commented May 27, 2021

We could have a validation that prevents the values to be x times greater than the default ones.
For example, right now the account reserve is 20 XRP, we could validate that the value selected by the user is not greater than 3x the default value (60 XRP in this example).
And that is greater than a min value, for example 5 XRP).

We need to establish some dynamic rule so we don’t hardcore any values in the tool.

I am open to other ideas, happy to add any approach we decide.

@alloynetworks
Copy link
Contributor Author

alloynetworks commented May 27, 2021

At this point, I am more inclined not to explicitly write the reserve vote into the rippled.cfg. Reason being even at this point, some validators who are on multiple UNLs have already voted for a lower reserve. So, if we include a value, we run the risk of people not updating their vote even if they are in agreement with the new reserves that could be in force.
https://xrpscan.com/validators
So, I guess I am changing my stand from my first message here 😃

@elmurci elmurci self-assigned this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants