-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reserves #2
Comments
Thanks for creating your first issue :-) |
Thanks @alloynetworks for this. If I read it correctly, you are saying that the tool should either remove the voting section to apply defaults or allow custom settings in the UI, right? |
That is correct. If a voting section isn't present, it will take defaults. However, the defaults are hard coded as it stands in |
We could have a validation that prevents the values to be x times greater than the default ones. We need to establish some dynamic rule so we don’t hardcore any values in the tool. I am open to other ideas, happy to add any approach we decide. |
At this point, I am more inclined not to explicitly write the reserve vote into the |
The
rippled.cfg
that is generated also creates the[voting]
values without prompt. This should be a form to either accept the default or set custom values.The text was updated successfully, but these errors were encountered: