Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LedgerResponseExpanded type for ledger RPC in APIv2 #2886

Open
pdp2121 opened this issue Jan 23, 2025 · 0 comments
Open

Fix LedgerResponseExpanded type for ledger RPC in APIv2 #2886

pdp2121 opened this issue Jan 23, 2025 · 0 comments
Labels

Comments

@pdp2121
Copy link
Collaborator

pdp2121 commented Jan 23, 2025

Context

ledger RPC responses with transactions and expand options enabled are structurally different between APIv1 and APIv2 in the transactions array:

For example:
v1:

"transactions": [
        {
          "validated": true,
          "ledger_index": 93637993,
          "close_time_iso": "2025-01-22T21:13:50Z",
          "ledger_hash": "058FDA696458896EC515AC19C3EDC8CD0E163A3620CA6B314165E5BAED70846A",
          "hash": "0346AECFA86DDF2ADE0C87AADD64D8B875980B7AC970B0CB9F0587E021B06AF5",
          "tx_json": {
            "Account": "rPrioTXJgZJF8bpdXq2X73PcVPfvYqjVKd",
            "DeliverMax": "1",
            "Destination": "rsRy14FvipgqudiGmptJBhr1RtpsgfzKMM",
            "DestinationTag": 321321,
            "Fee": "11",
            "Flags": 0,
            "LastLedgerSequence": 93638091,
            "Sequence": 93047513,
            "SigningPubKey": "EDE29EFE62F440CDDD6E537CE1C50C2711BFD8AC1CAE2CE20EAE77FB187F9ECBB8",
            "TransactionType": "Payment",
            "TxnSignature": "8FCBB4E86791B6B627739ED30BC2B8EFF44C56D82920D1F58DB0E465F3AA51195464EE92967CD01FEEA0FF4BFB81D585E6AC89569B0BA913E2CB66966251720F"
          },
          "meta": {
            ... meta data here
          }
        }
... other tx

v2:

"transactions": [
        {
          "Account": "rnD3H5GTySEt9DUjUeXLKP9hQ7beMzHxd9",
          "Amount": "10000000",
          "Destination": "rNxp4h8apvRis6mJf9Sh8C6iRxfrDWN7AV",
          "Fee": "10",
          "Flags": 2147483648,
          "LastLedgerSequence": 93638165,
          "Sequence": 70086956,
          "SigningPubKey": "03F9E4772BBFFE7E2E11B7F7564FB3DB252F7DE5BF7F0D215EC84AD5C63DD9AB77",
          "TransactionType": "Payment",
          "TxnSignature": "304402206F51A34077144F6B562A2EAC2CED227A6FFE31DBB5D8407358813E7B30B5639E02205EE3B2E0CCDF99E9844F40C4B033027EF117BB199A69DE8B75A1B7C14895F4B4",
          "hash": "044314FE34236A262DA692789CE5B48CA1A3CEC078B1A4ECCD65F4B61A9EB0A7",
          "DeliverMax": "10000000",
          "metaData": {... meta...}

To Do

The LedgerResponseExpanded defined here:
https://github.com/XRPLF/xrpl.js/blob/main/packages/xrpl/src/models/methods/ledger.ts#L291-L295
should be updated to reflect the changes in v2 (such as the new field tx_json, renaming of metaData to meta, etc.

@pdp2121 pdp2121 added the bug label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant