Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TransactionJSON tests to parameterize Flag values #467

Open
sappenin opened this issue Aug 3, 2023 · 0 comments
Open

Refactor TransactionJSON tests to parameterize Flag values #467

sappenin opened this issue Aug 3, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@sappenin
Copy link
Collaborator

sappenin commented Aug 3, 2023

For example, see EscrowJsonTests and its siblings. instead of having a bunch of different tests with various combinations of Flag settings, we should have a single "flags" test that is parameterized with the various flag settings.

In this way, each unit test will have roughly three unit tests, one for each of the following:

  • Fully hydrated model object.
  • Minimally hydrated model object.
  • Various combinations of Flags.
@sappenin sappenin added the enhancement New feature or request label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sappenin