Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unknown TransactionType #521

Open
rsteimen opened this issue Feb 4, 2024 · 1 comment
Open

Add support for unknown TransactionType #521

rsteimen opened this issue Feb 4, 2024 · 1 comment

Comments

@rsteimen
Copy link

rsteimen commented Feb 4, 2024

Add an UnknownTransaction object that can take the place of a transaction that xrpl4j doesn't yet support. For example, loading transactions from Xahau should not blow-up (but currently they would).

@sappenin
Copy link
Collaborator

sappenin commented Feb 6, 2024

Hi @rsteimen - thanks for filing this issue, and for your PR. Overall, I like the problem you're solving for, and need to review your PR to consider things more deeply (e.g., I think if we want to support this kind of change, we may want to align how we handle unknown LedgerObjects with the pattern/APIs you proposed).

Overall, I don't have a timeline for you here -- but wanted to "ack" your submission. Thanks for proposing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants