Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CI TODOs #43

Open
4 tasks
troyfeng116 opened this issue Apr 14, 2023 · 2 comments
Open
4 tasks

More CI TODOs #43

troyfeng116 opened this issue Apr 14, 2023 · 2 comments
Assignees
Milestone

Comments

@troyfeng116
Copy link
Collaborator

troyfeng116 commented Apr 14, 2023

  • Instead of configuring env vars locally on lada, configure from upstream (Github, repo?)
  • Read Github Actions secret management documentation, secret env var handling (configure with repo owner permissions?)
  • Run Actions in isolated VM to avoid executing malicious programs on lab servers
  • Dynamically assign GPUs based on lada workloads (write script to parse nvidia-smi output?)
@troyfeng116 troyfeng116 self-assigned this Apr 14, 2023
@niansong1996 niansong1996 added this to the arxiv milestone Apr 14, 2023
@troyfeng116
Copy link
Collaborator Author

NOTE: for reproducibility and local testing, environment variables need to be present on local machine to run local tests if tests depend on (use) environment variables.

Question: how to remotely/centrally manage environment variables used in testing, without exposing them in repository, so that 1) GH actions have access (i.e. env vars must be configured in Troy's ziva user space, where the self-hosted runner lives) and 2) all users who wish to run tests locally before pushing to a PR can do so?

If test files live on ziva (as they currently do), then tests will only pass if run locally on ziva (lab servers have distributed disk? so any lab server). However, developers on other machines will not be able to pass tests that depend on local data files, etc.

One solution: push all data files needed for tests to separate repo/registry, configure tests in isolated VM or docker container that pulls data files from registry. Then configure env vars upstream from Github?

@niansong1996
Copy link
Contributor

niansong1996 commented Apr 20, 2023

lab servers have distributed disk? so any lab server

Yes, lab servers have shared storage

I think we can leave this as low-pri for now (as marked in labels), I would say #42 is definitely higher priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants