Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ads keep playing in between tracks #159

Closed
webodan opened this issue Jul 22, 2023 · 3 comments
Closed

Some ads keep playing in between tracks #159

webodan opened this issue Jul 22, 2023 · 3 comments

Comments

@webodan
Copy link

webodan commented Jul 22, 2023

I'm using Arch, and I started using the spotify-adblock- git AUR package, which is kinda outdated, so I tried this compiling and trying out this git tree in an attempt to stop the annoying audio ads... but I just couldn't. The other ads don't appear (except for the empty UI space element with no ads in it mentioned in issue #12), just the audio ads, some even with video on them.

Hopefully we can find a fix.

@abba23
Copy link
Owner

abba23 commented Jul 22, 2023

the spotify-adblock- git AUR package, which is kinda outdated

It's not outdated. -git-packages will always build the latest commit.

[*] Config file: config.toml
[*] Error: Parse config file (TOML parse error at line 1, column 1
  |
1 | recent_files = [
  | ^^^^^^^^^^^^^^^^
missing field `allowlist`

The config file isn't right. Do you perhaps have some unrelated config.toml in your working directory when running Spotify with spotify-adblock?

@webodan
Copy link
Author

webodan commented Jul 22, 2023

Thanks, I'm an idiot! turns out there was some random config.toml in my home, I've been playing tracks for 30 minutes after deleting it and finally no more ads...

But in my defense i'll say... shouldn't the program always use its config file that's stored in /etc/spotify-adblock? and not whatever random config file it finds in the working directory that could be for something else.

@abba23
Copy link
Owner

abba23 commented Jul 22, 2023

shouldn't the program always use its config file that's stored in /etc/spotify-adblock? and not whatever random config file it finds in the working directory that could be for something else.

Overriding system-wide configuration like this is generally useful for development and custom user-specific configuration. While this behavior is described in the readme and problems should be pretty obvious from the terminal output, the name config.toml is admittedly rather generic, potentially leading to mix-ups like this. Changing the name or config loading behavior might be a consideration for the future if this turns out to be a problem for others as well.

@abba23 abba23 closed this as completed Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants