Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: two phase run #387

Open
lucasew opened this issue Jan 14, 2025 · 0 comments
Open

Feature Request: two phase run #387

lucasew opened this issue Jan 14, 2025 · 0 comments

Comments

@lucasew
Copy link

lucasew commented Jan 14, 2025

I have a Hugo site and Hugo has a characteristic where it needs to know the base url at build time to generate absolute links properly.

The problem is that it creates a egg and chicken problem where I need the base url to build the site but I need the artifact to know for sure what could be the base url.

Right now I am not doing preview deployments so it's not a huge deal as I can just hardcode the hostname, but it will if someone wants to do preview deploys.

Basically what I suggest is that the workflow creates the slot at first, gives the base URL and confirms the deploy as a finish step, like those cleanup tasks some workflows have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant