Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to distinguish between last commit and last comment dates on a PR #1114

Open
klagroix opened this issue Nov 27, 2023 · 1 comment
Labels
feature request New feature or request to improve the current logic need eyes Feature request needs additional triaging by leads

Comments

@klagroix
Copy link

Description:

Looking at the documentation, there appears to only be one flag to control the counter date: ignore-updates. Setting this to true changes the action to look at created_at instead of updated_at.

For my use-case, I'd like to be able to distinguish between last-commit time and last-comment time. Unless I'm mistaken, there doesn't appear to be a way to do this.

It looks like this functionality was introduced in #494 but then reverted in #507 but I can't see exactly why that was done.

Justification:
I have a CI job that builds a container image on each commit and pushes it to a private image repository. That image repository has a lifecycle rule that deletes the image after X days.

There is also automation that looks for PRs with a particular label and spins up a test environment for testing the branch.

I was hoping to use the stale GH action to remove the label from the PR after X days since the last commit (to line up with the lifecycle rule for the private image repository). In this case, I do not care about comments on the PR

Are you willing to submit a PR?

@klagroix klagroix added feature request New feature or request to improve the current logic needs triage labels Nov 27, 2023
@nikolai-laevskii
Copy link
Contributor

Thank you for the feature request. We will consider implementing it and return with an update!

@nikolai-laevskii nikolai-laevskii added need eyes Feature request needs additional triaging by leads and removed needs triage labels Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic need eyes Feature request needs additional triaging by leads
Projects
None yet
Development

No branches or pull requests

2 participants