Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[env-switcher] Clicking Preview/Live takes you to the main branch #365

Open
alexcarol opened this issue Nov 18, 2024 · 1 comment
Open

Comments

@alexcarol
Copy link

alexcarol commented Nov 18, 2024

Expected Behaviour

The "preview" and "live" buttons in the env switcher should match the current branch you're using in the environment.

Actual Behaviour

They're defaulting to main

Reproduce Scenario (including but not limited to)

When switching environments while in a branch environment

Steps to Reproduce

  1. Open the site on a url for a specific branch in preview/live environments
  2. Click live/preview on the environment selector
  3. You're now in the main branch environment

Platform and Version

Chrome Version 130.0.6723.116 (Official Build) (arm64)
Sidekick 7.1.1

Sample Code that illustrates the problem

--

Logs taken while reproducing problem

--

@rofe
Copy link
Contributor

rofe commented Nov 19, 2024

The current v7 behavior is identical to v6, but I agree that it would be practical/expected to stay on a specific branch. However, when switching to the editor and back, it isn't possible to retain the branch. So I'm wondering if always switching to main - like we do now - is the more consistent behavior...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants