Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Project enabled' dialog does not appear when user enables project #374

Open
Adobe-G11N-I18N-L10N-Team opened this issue Nov 28, 2024 · 2 comments

Comments

@Adobe-G11N-I18N-L10N-Team

Expected Behaviour

'Project enabled' dialog appears when user enables project

Actual Behaviour

'Project enabled' dialog does not appear when "Enable this project" button is clicked

Reproduce Scenario (including but not limited to)

Steps to Reproduce

  1. Install extension
  2. Go to project folder
  3. Add project to Sidekick
  4. Disable project
  5. Click on Sidekick button > Enable this project

Platform and Version

Chrome 131.0.6778.86
Sidekick v7.1.2

Strings from the dialog are present in code

2024-11-28.15-44-10.mp4
@kmurugulla kmurugulla self-assigned this Jan 15, 2025
@kmurugulla
Copy link
Collaborator

@rofe - in the v7.2.0 , both disable and enable actions are not producing the dialog. want to check whether the requirements changed or should the dialogs must show for both enable and disable ? appreciate your inputs.

@kmurugulla kmurugulla removed their assignment Jan 15, 2025
@rofe
Copy link
Contributor

rofe commented Jan 16, 2025

I think it might be flaky, but I'm still able to get a "project disabled" dialog. I think both actions should work symmetrically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants