Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Popover plugins #474

Open
dylandepass opened this issue Feb 18, 2025 · 1 comment · Fixed by #475
Open

Support for Popover plugins #474

dylandepass opened this issue Feb 18, 2025 · 1 comment · Fixed by #475
Assignees
Labels
enhancement New feature or request released

Comments

@dylandepass
Copy link
Member

dylandepass commented Feb 18, 2025

Popovers are a small, floating UI element that appears near a trigger (e.g., plugin button) when clicked.

Image

Features

  • Developers should have control over the popover width and height.
    • Introduce a new popoverRect plugin property that is used in the style of the iframe. Similar to paletteRect.
  • The popover should include the current theme in the iframe’s src (query param) to allow theme styling.
  • The iframe should support transparency

Example plugin config. New isPopover boolean.

{
   "id": "reviews",
   "title": "Review",
   "isPopover": true,
   "popoverRect": "width:200px; height: 200px",
   "url": "https://labs.aem.live/tools/snapshot-admin/palette.html",
   "environments": [
      "preview"
   ]
}
@dylandepass dylandepass self-assigned this Feb 18, 2025
@dylandepass dylandepass added the enhancement New feature or request label Feb 18, 2025
@trieloff
Copy link

🎉 This issue has been resolved in version 7.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants