1012 remote state managed scopes #1176
Conversation
src/main/java/de/adorsys/keycloak/config/service/ClientScopeImportService.java
Outdated
Show resolved
Hide resolved
| assertThat(scopeMappingRoles, hasSize(1)); | ||
| assertThat(scopeMappingRoles, contains("added-scope-mapping-role")); | ||
|
|
||
| assertThat(scopeMappings, hasSize(3)); |
There was a problem hiding this comment.
why remove the test implimentation for the scope-mapping ?
There was a problem hiding this comment.
Why the Test Was Changed:
Why the Test Was Changed:
-
The test was updated to reflect the expected behavior after the import, where the scope-mapping for
scope-mapping-clientshould remain in the scope mappings. This aligns with the updated configuration, wherescope-mapping-clientis not deleted during the import. -
The number of scope mappings has increased to 3 because the deletion of
scope-mapping-clientwas not expected, and we need to accurately represent the realm's state after the import.
Additionally, the change in the CLI option --import.managed.scope-mapping from full to no-delete was causing conflicts in the test. The updated test now reflects this change and ensures that the scope-mapping for scope-mapping-client remains, as intended by the configuration.
There was a problem hiding this comment.
Hello @Calebasah the current behavior seems to diverge from the error posted by @sky-754 please review it and maybe he should and more clarity on the ticket
thanks
Hello @AssahBismarkabah thank you for your feedback, I've reviewed the expected behavior and ensured that it is clearly stated here. |
|
|
Hi @Calebasah I've noticed that the manually created ScopMappings still appear to be deleted following the recent changes? |
What this PR does / why we need it:
This PR addresses inconsistencies in the realm import process when
--import.remote-state.enabled=true. It improves the handling of scope mapping and client mapping. This enhancement ensures reliable and repeatable configuration imports.Which issue this PR fixes (#1012)
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR