Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec.json combining marks #27

Open
djstrong opened this issue Jan 31, 2024 · 2 comments
Open

spec.json combining marks #27

djstrong opened this issue Jan 31, 2024 · 2 comments

Comments

@djstrong
Copy link

I have checked some data from spec.json. There are combining marks under cm key and "valid" characters from groups (primary and secondary). Some combining marks are in these valid characters some are not (948). Why is that?
One example is character 20E3 (present in cm, absent in any group, it is part of an emoji). Here https://adraffy.github.io/ens-normalize.js/test/chars.html it is marked as disallowed.
Other example is 20DD - present in cm, absent in any group, but it is not part of any emoji.

@adraffy
Copy link
Owner

adraffy commented Jan 31, 2024

The extra data is so is_combining_mark() can be correct independent of ENSIP-15. For example, it useful to know if a character is a CM inside of an error message for a disallowed character.

@adraffy
Copy link
Owner

adraffy commented Jan 31, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants