Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If pip install -r requirements.txt fails during an agent run, agent run should be aborted #364

Open
andyk opened this issue Apr 18, 2022 · 2 comments

Comments

@andyk
Copy link
Contributor

andyk commented Apr 18, 2022

currently, a component does not check if virtualenv setup succeeds or fails since when I try to run papag, I'm seeing the pip install -r requirements.txt fail since i didn't have cmake installed on my machine. Currently the agent run command just ignores that the virtualenv requirement installation failed and tries to run the agent anyway, resulting in a confusing/misleading error message.

@andyk
Copy link
Contributor Author

andyk commented Apr 18, 2022

@nickjalbert just FYI i hit this. it's a small-ish thing since you can deduce that the pip install of requirements failed by reading error output of the run command anyway, but as it is, it takes a little bit more cognitive energy to figure that out

@nickjalbert
Copy link
Contributor

Yeah, would be good to fix! Will wait until it's prioritized (or until I need something small to do)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants