Skip to content

Commit e7ea0f1

Browse files
committed
feat: non inclusive start block
1 parent 18fbeaa commit e7ea0f1

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

crates/aggchain-proof-builder/src/lib.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ pub struct AggchainProofBuilderRequest {
3939
/// Aggregated full execution proof for the number of aggregated block
4040
/// spans.
4141
pub agg_span_proof: SP1ProofWithPublicValues,
42-
/// First block in the aggregated span.
42+
/// First block in the aggregated span, this block would not be proved by op-succint.
4343
pub start_block: u64,
4444
/// Last block in the aggregated span (inclusive).
4545
pub end_block: u64,
@@ -61,7 +61,7 @@ pub struct AggchainProofBuilderRequest {
6161
pub struct AggchainProofBuilderResponse {
6262
/// Generated aggchain proof for the block range.
6363
pub proof: SP1Proof,
64-
/// First block included in the aggchain proof.
64+
/// First block included in the aggchain proof, this block would not be proved by op-succint.
6565
pub start_block: u64,
6666
/// Last block included in the aggchain proof.
6767
pub end_block: u64,

crates/aggchain-proof-service/src/service.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ use crate::error::Error;
2222
#[derive(Default, Clone, Debug)]
2323
#[allow(unused)]
2424
pub struct AggchainProofServiceRequest {
25-
/// Aggchain proof starting block
25+
/// Aggchain proof starting block, this block would not be proved by op-succint.
2626
pub start_block: u64,
2727
/// Max number of blocks that the aggchain proof is allowed to contain
2828
pub max_block: u64,
@@ -44,7 +44,7 @@ pub struct AggchainProofServiceResponse {
4444
/// Aggchain proof generated by the `aggchain-proof-builder` service
4545
/// per `agg-sender` request.
4646
pub proof: SP1Proof,
47-
/// First block in the aggchain proof.
47+
/// First block in the aggchain proof, this block would not be proved by op-succint.
4848
pub start_block: u64,
4949
/// Last block in the aggchain proof (inclusive).
5050
pub end_block: u64,
Binary file not shown.

crates/aggkit-prover-types/src/generated/aggkit.prover.v1.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
/// The request message for generating aggchain proof.
33
#[derive(Clone, PartialEq, ::prost::Message)]
44
pub struct GenerateAggchainProofRequest {
5-
/// The start block for which the aggchain proof is requested.
5+
/// The start block for which the aggchain proof is requested, this block would not be proved by op-succint.
66
#[prost(uint64, tag = "1")]
77
pub start_block: u64,
88
/// The max end block for which the aggchain proof is requested.
@@ -35,7 +35,7 @@ pub struct GenerateAggchainProofResponse {
3535
/// Aggchain proof.
3636
#[prost(bytes = "vec", tag = "1")]
3737
pub aggchain_proof: ::prost::alloc::vec::Vec<u8>,
38-
/// The start block of the aggchain proof.
38+
/// The start block of the aggchain proof, this block would not be proved by op-succint.
3939
#[prost(uint64, tag = "2")]
4040
pub start_block: u64,
4141
/// The end block of the aggchain proof.

crates/aggkit-prover/src/rpc.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ impl AggchainProofGrpcService for GrpcService {
3737
request: Request<GenerateAggchainProofRequest>,
3838
) -> Result<Response<GenerateAggchainProofResponse>, Status> {
3939
let request = request.into_inner();
40-
if request.max_end_block < request.start_block {
40+
if request.max_end_block <= request.start_block {
4141
let mut error = ErrorDetails::new();
4242
error.add_bad_request_violation(
4343
"max_end_block",

proto/aggkit/prover/v1/aggchain_proof_generation.proto

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ service AggchainProofService {
1010

1111
// The request message for generating aggchain proof.
1212
message GenerateAggchainProofRequest {
13-
// The start block for which the aggchain proof is requested.
13+
// The start block for which the aggchain proof is requested, this block would not be proved by op-succint.
1414
uint64 start_block = 1;
1515
// The max end block for which the aggchain proof is requested.
1616
uint64 max_end_block = 2;
@@ -30,7 +30,7 @@ message GenerateAggchainProofRequest {
3030
message GenerateAggchainProofResponse {
3131
// Aggchain proof.
3232
bytes aggchain_proof = 1;
33-
// The start block of the aggchain proof.
33+
// The start block of the aggchain proof, this block would not be proved by op-succint.
3434
uint64 start_block = 2;
3535
// The end block of the aggchain proof.
3636
uint64 end_block = 3;

0 commit comments

Comments
 (0)