feat: non inclusive start block

Author: invocamanman

crates/aggchain-proof-builder/src/lib.rs

@@ -39,7 +39,10 @@ pub struct AggchainProofBuilderRequest {
     /// Aggregated full execution proof for the number of aggregated block
     /// spans.
     pub agg_span_proof: SP1ProofWithPublicValues,
-    /// First block in the aggregated span.
+    // Start block of the aggregated span proof. This block must match the end_block of the last
+    // proof. Even if it's needed in the input to match the previous one this block it's
+    // already proven. Therefore proving goes from start_block+1 to end_block  both inclusive.
+    // Proof (start_block, end_block]
     pub start_block: u64,
     /// Last block in the aggregated span (inclusive).
     pub end_block: u64,
@@ -61,7 +64,7 @@ pub struct AggchainProofBuilderRequest {
 pub struct AggchainProofBuilderResponse {
     /// Generated aggchain proof for the block range.
     pub proof: SP1Proof,
-    /// First block included in the aggchain proof.
+    /// Start block of the aggregated span proof.
     pub start_block: u64,
     /// Last block included in the aggchain proof.
     pub end_block: u64,

crates/aggchain-proof-service/src/service.rs

@@ -22,7 +22,7 @@ use crate::error::Error;
 #[derive(Default, Clone, Debug)]
 #[allow(unused)]
 pub struct AggchainProofServiceRequest {
-    /// Aggchain proof starting block
+    /// Start block of the aggregated span proof.
     pub start_block: u64,
     /// Max number of blocks that the aggchain proof is allowed to contain
     pub max_block: u64,
@@ -44,7 +44,7 @@ pub struct AggchainProofServiceResponse {
     /// Aggchain proof generated by the `aggchain-proof-builder` service
     /// per `agg-sender` request.
     pub proof: SP1Proof,
-    /// First block in the aggchain proof.
+    /// Start block of the aggregated span proof.
     pub start_block: u64,
     /// Last block in the aggchain proof (inclusive).
     pub end_block: u64,

crates/aggkit-prover-types/src/generated/aggkit.prover.bin

@@ -2,7 +2,10 @@
 /// The request message for generating aggchain proof.
 #[derive(Clone, PartialEq, ::prost::Message)]
 pub struct GenerateAggchainProofRequest {
-    /// The start block for which the aggchain proof is requested.
+    /// Start block of the aggchain proof. This block must match the end_block of the last proof.
+    /// Even if it's needed in the input to match the previous one this block it's already proven.
+    /// Therefore proving goes from start_block+1 to end_block  both inclusive.
+    /// Proof (start_block, end_block]
     #[prost(uint64, tag = "1")]
     pub start_block: u64,
     /// The max end block for which the aggchain proof is requested.
@@ -35,7 +38,7 @@ pub struct GenerateAggchainProofResponse {
     /// Aggchain proof.
     #[prost(bytes = "vec", tag = "1")]
     pub aggchain_proof: ::prost::alloc::vec::Vec<u8>,
-    /// The start block of the aggchain proof.
+    /// Start block of the aggregated span proof.
     #[prost(uint64, tag = "2")]
     pub start_block: u64,
     /// The end block of the aggchain proof.

crates/aggkit-prover-types/src/generated/aggkit.prover.v1.rs

@@ -37,7 +37,7 @@ impl AggchainProofGrpcService for GrpcService {
         request: Request<GenerateAggchainProofRequest>,
     ) -> Result<Response<GenerateAggchainProofResponse>, Status> {
         let request = request.into_inner();
-        if request.max_end_block < request.start_block {
+        if request.max_end_block <= request.start_block {
             let mut error = ErrorDetails::new();
             error.add_bad_request_violation(
                 "max_end_block",

crates/aggkit-prover/src/rpc.rs

@@ -10,7 +10,10 @@ service AggchainProofService {
 
 // The request message for generating aggchain proof.
 message GenerateAggchainProofRequest {
-  // The start block for which the aggchain proof is requested.
+  // Start block of the aggchain proof. This block must match the end_block of the last proof.
+  // Even if it's needed in the input to match the previous one this block it's already proven.
+  // Therefore proving goes from start_block+1 to end_block  both inclusive.
+  // Proof (start_block, end_block]
   uint64 start_block = 1;
   // The max end block for which the aggchain proof is requested.
   uint64 max_end_block = 2;
@@ -30,7 +33,7 @@ message GenerateAggchainProofRequest {
 message GenerateAggchainProofResponse {
   // Aggchain proof.
   bytes aggchain_proof = 1;
-  // The start block of the aggchain proof.
+  // Start block of the aggregated span proof.
   uint64 start_block = 2;
   // The end block of the aggchain proof.
   uint64 end_block = 3;