Replies: 1 comment 1 reply
-
what do you think of letting the environment classes define the select_start_nodes and get_num_starts functions? |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
At the moment, we have a
select_start_nodes
(here) that is not very modular (i.e. for each environment, you have to manually make an "if---else"). Also, it is not clear at all for newcomers. We should make this as a class such that a user can create their own and pass it.In the same class, we should also include a method to get the number of starts for the environment (e.g. for PDP, we have half of the nodes as possible starting points)
Related: See #108
Beta Was this translation helpful? Give feedback.
All reactions