Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the new parameters optional, with a default value in case they are not set #1373

Closed
ajnart opened this issue Sep 7, 2023 · 2 comments
Closed
Labels
🐛 Bug Something isn't working Stale

Comments

@ajnart
Copy link
Owner

ajnart commented Sep 7, 2023

homarr/src/types/app.ts

Lines 35 to 40 in 1651361

interface AppAppearanceType {
iconUrl: string;
appNameStatus: "normal"|"hover"|"hidden";
positionAppName: Property.FlexDirection;
lineClampAppName: number;
}

This should be quite clear. Don't make these values required, they should have a "normal" / "default" value in case they are not present in the config (which is the way it was before adding more freedom to change it)

@ajnart ajnart added the 🐛 Bug Something isn't working label Sep 7, 2023
@ajnart
Copy link
Owner Author

ajnart commented Sep 7, 2023

@Tagaishi

Copy link

github-actions bot commented Jan 4, 2024

Hello 👋, this issue has been open for 60 without activity. Please close this issue if it's no longer relevant or has been resolved. Still relevant? Simply reply and I'll mark it as active.

@github-actions github-actions bot added the Stale label Jan 4, 2024
@manuel-rw manuel-rw closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Homarr Kanban May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working Stale
Projects
Archived in project
Development

No branches or pull requests

2 participants