Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsignedTx from the generated deployment file #314

Open
polarker opened this issue Feb 20, 2024 · 1 comment
Open

Remove unsignedTx from the generated deployment file #314

polarker opened this issue Feb 20, 2024 · 1 comment
Assignees

Comments

@polarker
Copy link
Member

It's a bit heavy and not necessary since tx id is stored

@Lbqds
Copy link
Member

Lbqds commented Feb 26, 2024

When the user calls deployer.deployContract, they might want to check the unsignedTx. So there is an unsignedTx field in the DeployContractResult. We store the unsignedTx in the deployment file because if the contract has already been deployed, we can directly return the result from here.

However, it's still possible to remove unsignedTx from the deployment file. We can get tx info from the full node using the tx id, but we cannot directly get the encoded unsigned tx. We can use tx-codec to encode it into a hex string. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants