Skip to content

Commit 5a1d204

Browse files
committed
requirements: Drop the --no-binary for lxml and xmlsec.
Building these libraries from source requires too much memory, and causes OOMs on a host with 4GB of RAM when still running Zulip. Building from source was enabled in `main` to work around xmlsec/python-xmlsec#320, which does not occur with the xmlsec version in the 8.x branch, as xmlsec/python-xmlsec#314 (incompatibilities with Ubuntu 20.04) causes us to pin xmlsec<1.3.14. As such, we switch back to using prebuilt wheels. The version mismatch from xmlsec/python-xmlsec#320, if real, is not new, so this exposes us to no more risk than before.
1 parent 5e8cc22 commit 5a1d204

File tree

3 files changed

+0
-8
lines changed

3 files changed

+0
-8
lines changed

requirements/common.in

-2
Original file line numberDiff line numberDiff line change
@@ -128,14 +128,12 @@ social-auth-app-django
128128
social-auth-core[azuread,openidconnect,saml]
129129
python3-saml
130130
xmlsec<1.3.14 # https://github.com/xmlsec/python-xmlsec/issues/314
131-
--no-binary=xmlsec
132131

133132
# For encrypting a login token to the desktop app
134133
cryptography
135134

136135
# Needed for messages' rendered content parsing in push notifications.
137136
lxml
138-
--no-binary=lxml
139137

140138
# Needed for 2-factor authentication
141139
django-two-factor-auth[call,phonenumberslite,sms]

requirements/dev.txt

-3
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@
77
#
88
# For details, see requirements/README.md .
99
#
10-
--no-binary lxml
11-
--no-binary xmlsec
12-
1310
aioapns==3.2 \
1411
--hash=sha256:40f6b2428816f7bb1a32668f50fe71d0289777a429b60fce44e8a08b90123508 \
1512
--hash=sha256:99416ed2916fb6302294188a2caf85ec2b8ea3b988f466add73f9dc2c7ca5dc2

requirements/prod.txt

-3
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@
77
#
88
# For details, see requirements/README.md .
99
#
10-
--no-binary lxml
11-
--no-binary xmlsec
12-
1310
aioapns==3.2 \
1411
--hash=sha256:40f6b2428816f7bb1a32668f50fe71d0289777a429b60fce44e8a08b90123508 \
1512
--hash=sha256:99416ed2916fb6302294188a2caf85ec2b8ea3b988f466add73f9dc2c7ca5dc2

0 commit comments

Comments
 (0)