feat: add api-workflow plugin #1229
Conversation
|
|
|
@lixf311 上面的CLA要签署一下 |
|
ok~ |
|
@lixf311 加一下我钉钉吧：chengtanzty |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1229 +/- ##
==========================================
+ Coverage 35.91% 35.96% +0.05%
==========================================
Files 69 69
Lines 11576 9500 -2076
==========================================
- Hits 4157 3417 -740
+ Misses 7104 5767 -1337
- Partials 315 316 +1 |
| @@ -0,0 +1,376 @@ | |||
| ## 功能说明 | |||
There was a problem hiding this comment.
README的格式可以参考下ai-proxy的方便后续放到官网上
| | service_headers | array of header object | 选填 | | 请求的头 | | | ||
| | service_body_replace_keys| array of bodyReplaceKeyPair object | 选填| 请求body模板替换键值对 | 用来构造请求| 如果为空，则直接使用service_body_tmpl请求 | | ||
| | service_body_tmpl | string | 选填 | | 请求的body模板 | | | ||
| | service_type | string | 必填 | | 请求的类型 | static，domain | |
There was a problem hiding this comment.
这里不需要区分service_type，Cluster使用FQDNCluster可以适配所有方式。配置时，如果是static类型，service_name使用xxx.static，如果是dns类型，service_name使用xxx.dns
| func onHttpRequestBody(ctx wrapper.HttpContext, config PluginConfig, body []byte, log wrapper.Log) types.Action { | ||
|
|
||
| initHeader := make([][2]string, 0) | ||
| //初始化运行状态 |
There was a problem hiding this comment.
注释格式可以调整下 统一成//后面加个空格
// 初始化运行状态 |
|
||
| initHeader := make([][2]string, 0) | ||
| //初始化运行状态 | ||
| workflowExecStatus, err := initWorkflowExecStatus(config) |
There was a problem hiding this comment.
这个初始状态是否可以在parseConfig的时候就定义好，我看这里只用到了config的信息，不涉及每个请求的具体信息
| initHeader := make([][2]string, 0) | ||
| //初始化运行状态 | ||
| workflowExecStatus, err := initWorkflowExecStatus(config) | ||
| log.Errorf("init status : %v", workflowExecStatus) |
| } | ||
| return | ||
|
|
||
| }, uint32(maxDepth)*5000) |
| */ | ||
| type CompareFunc func(a, b float64) bool | ||
|
|
||
| var operators = map[string]interface{}{ |
There was a problem hiding this comment.
由于tinygo的一些限制（比如不能使用反射等）不能直接使用类似https://github.com/vulcand/predicate 的go第三方库，我们可以参考下这个库的设计和实现，丰富一些类似And和Or的能力（只是建议，可以优化下代码实现，具体是否丰富功能看当前场景下是否需要）
| w.Task.Cluster = wrapper.FQDNCluster{ | ||
| FQDN: node.ServiceName, | ||
| Port: node.ServicePort, | ||
| } |
| @@ -0,0 +1,21 @@ | |||
| module github.com/alibaba/higress/plugins/wasm-go/extensions/ai-workflow | |||
There was a problem hiding this comment.
module名称叫ai-workflow即可
| "github.com/higress-group/proxy-wasm-go-sdk/proxywasm/types" | ||
| "github.com/tidwall/gjson" | ||
| "net/http" | ||
| ) |
There was a problem hiding this comment.
调整下go import的顺序吧，代码编辑器一般都有这个设置
goland的话可以参考下这个：https://blog.csdn.net/t949500898/article/details/123330231
|
|
||
| var operators = map[string]interface{}{ | ||
| //CompareFunc 用来比较float64 数据大小: | ||
| "eq": func(a, b float64) bool { return a == b }, |
There was a problem hiding this comment.
只支持数值类型的比较吗？这种场景下字符串的比较可能更常见一些
johnlanni
changed the title
Ⅰ. Describe what this PR did
Add ai-workflow plugin，the first version only supports tools.
Ⅱ. Does this pull request fix one issue?
fixes #1225
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews