Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eureka and other service discovery mechanisms require validation to prevent illegal IP field entries. #1299

Open
johnlanni opened this issue Sep 11, 2024 · 0 comments · May be fixed by #1322
Open

Eureka and other service discovery mechanisms require validation to prevent illegal IP field entries. #1299

johnlanni opened this issue Sep 11, 2024 · 0 comments · May be fixed by #1322
Labels
help wanted Extra attention is needed level/normal sig/microservice

Comments

@johnlanni
Copy link
Collaborator

johnlanni commented Sep 11, 2024 •
edited
Loading

Originally posted by @johnlanni in #1284 (comment)

As an example, modify here with Eureka:

higress/registry/eureka/watcher.go

Line 273 in f471c0a

Address: instance.IPAddr,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed level/normal sig/microservice
Projects
Higress
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: when there is a non-ip IPAddr in Eureka, delete it to avoid a failure in EDS lcfang/higress
1 participant
@johnlanni