Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Actions] Add OpenAPI linting #221

Closed
justinyoo opened this issue Aug 17, 2024 · 3 comments · Fixed by #243
Closed

[GitHub Actions] Add OpenAPI linting #221

justinyoo opened this issue Aug 17, 2024 · 3 comments · Fixed by #243

Comments

@justinyoo
Copy link
Contributor

@justinyoo
Copy link
Contributor Author

sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 19, 2024
Add settings for OpenAPI linting in build stage

Related to: aliencube#221
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 19, 2024
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 19, 2024
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 19, 2024
* update AzureOpenAIProxy.ApiApp.csproj to add OpenAPI linting

Add settings for OpenAPI linting in build stage

Related to: aliencube#221

* update github workflow settings

Related to: aliencube#221
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 19, 2024
spectral-action requires "check: write" permission

Related to: aliencube#221
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 20, 2024
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 20, 2024
* update AzureOpenAIProxy.ApiApp.csproj to add OpenAPI linting

Add settings for OpenAPI linting in build stage

Related to: aliencube#221

* update github workflow settings

Related to: aliencube#221

* update permission in github workflow

spectral-action requires "check: write" permission

Related to: aliencube#221

* fix file_glob path in OpenAPI linting

Related to: aliencube#221
@justinyoo
Copy link
Contributor Author

@sikutisa 여기에 코멘트 먼저 남겨서 작업 시작한다고 하고 시작해 주세요. 그래야 제가 이 이슈를 할당할수 있습니다

@justinyoo justinyoo linked a pull request Aug 21, 2024 that will close this issue
@sikutisa
Copy link
Contributor

현재 제가 작업하고 있습니다.

sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 22, 2024
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 22, 2024
Since openapi.json does not always need to be created after build,
the command is separated from the csproj file into a github action task.

Related to: aliencube#221
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 23, 2024
To keep the Verb + Object format

Related to: aliencube#221
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 24, 2024
spectral cli is not suitable for providing report

Related to: aliencube#221
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 24, 2024
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 24, 2024
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 24, 2024
Because of github token and permisson issues

Related to: aliencube#221
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 24, 2024
Because of github token and permisson issues

Related to: aliencube#221
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 24, 2024
remove swashbuckle-cli because openapi.json created by swashbuckle-cli
does not contains OpenAPI servers info.

In github task, Waring is also treated as Error on this project.

Related to: aliencube#221
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 24, 2024
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 24, 2024
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 24, 2024
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 24, 2024
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Aug 24, 2024
seperate run integration tests job to Run AzureOpenAIProxy.AppHost in
background and Run integration tests

Related to: aliencube#221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants