Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes browser to crash. #57

Open
KesavarajaRK opened this issue Mar 18, 2024 · 3 comments
Open

Makes browser to crash. #57

KesavarajaRK opened this issue Mar 18, 2024 · 3 comments

Comments

@KesavarajaRK
Copy link

Issue: Browser crashes with frequent undo.
Reproduce Steps:

  1. Add more than 300 objects into the canvas.
  2. Execute undo every second.
  3. Browser asks to wait or stop the process. Continue with wait.
  4. Once page is back giving undo back-to-back ends with crashing the browser with blank page.
@harryngdev
Copy link

Same issue. Do you have a solution yet?

@alimozdemir
Copy link
Owner

Hi, this library is a pretty basic implementation of history logic. 300 objects can be a problem, and it also depends on the object's details as well. To be able to support such logic, you might need to use some other storage and logic, e.g., max 100 history, and the rest will be deleted as FIFO.

@harryngdev
Copy link

Ok, thanks u so much. An unrelated problem with your library, please help.
When I add an image to Canvas, if I add it as url then when I output with toDataURL it gives the error "Failed to execute 'toDataURL' on 'HTMLCanvasElement': Tainted canvases may not be exported.", currently I am bypassing by converting a to base64, but when I work with about 300 objects then it started lagging, don't know if you have any solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants