You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Observation
This package uses the native namespace packaging approach (no init file in fs folder). Also, this package depends on pyfilesystem2 and shares this namespace folder 'fs' with pyfilesystem2.
However, pyfilesystem2 uses the pkg_resources-style namespace approach to declare its namespace folder 'fs' (see fs/init.py).
As a result, this package is inconsistent with the recommendation in pkg_resources-style namespace approach -
If you are creating a new distribution within an existing namespace package that uses this method then it’s recommended to continue using this as the different methods are not cross-compatible and it’s not advisable to try to migrate an existing package.
Problem
In use cases where these two packages are downloaded in seperate directories and both of them are added to the python systempath, the package import does not work due to the aforementioned inconsistency. This is exactly the problem if one uses bazel to manage these external dependencies in a project.
Suggestion
Please use the consistent namespace packaging convention as suggested in the link above.
The text was updated successfully, but these errors were encountered:
shiviser
changed the title
Inconsistent namespace approach
Inconsistent namespace packaging approach
Mar 11, 2021
Observation
This package uses the native namespace packaging approach (no init file in fs folder). Also, this package depends on pyfilesystem2 and shares this namespace folder 'fs' with pyfilesystem2.
However, pyfilesystem2 uses the pkg_resources-style namespace approach to declare its namespace folder 'fs' (see fs/init.py).
As a result, this package is inconsistent with the recommendation in pkg_resources-style namespace approach -
Problem
In use cases where these two packages are downloaded in seperate directories and both of them are added to the python systempath, the package import does not work due to the aforementioned inconsistency. This is exactly the problem if one uses bazel to manage these external dependencies in a project.
Suggestion
Please use the consistent namespace packaging convention as suggested in the link above.
The text was updated successfully, but these errors were encountered: