New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve decoding path segments #16

Open

kelunik opened this issue Sep 15, 2024 · 1 comment

Member

kelunik commented Sep 15, 2024

See #15 (comment)

Here is my case:

Path is /.well-known/mercure/subscriptions/https%3A%2F%2Fexample.com%2Fmy-other-topic

The current code is transforming it to /.well-known/mercure/subscriptions/https://example.com/my-other-topic

It prevents fastroute to route correctly with the route /.well-known/mercure/subscriptions/{topic}. Maybe adding a test case with my case would be nice?

See also: https://github.com/amphp/http-server-router?tab=readme-ov-file#limitations

The text was updated successfully, but these errors were encountered:

Member Author

kelunik commented Sep 15, 2024

Symfony seems to have the exact same behavior as we currently have: https://symfony.com/doc/current/routing.html#slash-characters-in-route-parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment